Return to BSD News archive
Xref: sserve comp.os.386bsd.development:624 comp.os.386bsd.misc:254 comp.os.386bsd.questions:2074
Newsgroups: comp.os.386bsd.development,comp.os.386bsd.misc,comp.os.386bsd.questions
Path: sserve!newshost.anu.edu.au!munnari.oz.au!metro!news
From: dawes@physics.su.OZ.AU (David Dawes)
Subject: Re: Leadership
Message-ID: <1993Apr30.035747.26283@ucc.su.OZ.AU>
Sender: news@ucc.su.OZ.AU
Nntp-Posting-Host: physics.su.oz.au
Organization: School of Physics, University of Sydney, Australia
References: <C5yH0F.Hn6@ns1.nodak.edu> <C645Dx.4zp@sugar.neosoft.com> <C68oBG.Bup@flatlin.ka.sub.org>
Date: Fri, 30 Apr 1993 03:57:47 GMT
Lines: 33
In article <C68oBG.Bup@flatlin.ka.sub.org> bad@flatlin.ka.sub.org (Christoph Badura) writes:
>In <C645Dx.4zp@sugar.neosoft.com> peter@NeoSoft.com (Peter da Silva) writes:
>
>>It would really help if Lynne could let us know *which* 1/3 of the patches
>>are bogus, eh?
>
>For example the original fix that is supposed to prevent make from
>removing directories. Something like:
>
> if (!(statbuf.st_mode & S_IFDIR)) {
>
>I sent a fix for that two times to the then current patchkit
>coordinator with no response. I haven't checked the latest patchkits.
I fear that bogus fix was taken from a hasty posting of mine a long time
ago. I also contacted one of the patchkit moderators about fixing it
(not the current moderator), but I see that it is still incorrect as of
0.2.3.
For the record, the correct code is:
if (!S_ISDIR(statbuf.st_mode)) {
[this occurs in two places: usr.bin/make/{compat,job}.c]
David
--
------------------------------------------------------------------------------
David Dawes <dawes@physics.su.oz.au> DoD#210 | Phone: +61 2 692 2639
School of Physics, University of Sydney, Australia | Fax: +61 2 660 2903
------------------------------------------------------------------------------
I was so satisfied, deep down inside, like a hand in a velvet glove -- AC/DC
------------------------------------------------------------------------------