Return to BSD News archive
Path: sserve!newshost.anu.edu.au!munnari.oz.au!news.Hawaii.Edu!ames!elroy.jpl.nasa.gov!swrinde!gatech!udel!sbcs.sunysb.edu!stark.UUCP!gene From: gene@cs.sunysb.edu!stark (Gene Stark) Newsgroups: comp.os.386bsd.bugs Subject: Re: pk0.2.4: error with DKFL_QUIET (wd.c), w/ patch Date: 17 Jul 93 07:38:41 Organization: Gene Stark's home system Lines: 38 Message-ID: <GENE.93Jul17073841@stark.uucp> References: <1993Jul16.125843.6987@hq.demos.su> NNTP-Posting-Host: stark.uucp In-reply-to: apg@demos.su's message of Fri, 16 Jul 1993 12:58:43 GMT In article <1993Jul16.125843.6987@hq.demos.su> apg@demos.su (Paul Antonov) writes: With newest patchkit 0.2.4 it's virtually impossible to install 386bsd to empty disk drive because of small bug in wd.c: DKFL_QUIET must be set if proper disklabel doesn't exist. [patch omitted] Actually, wouldn't it be better to revert to the way the old driver was: to set DKFL_QUIET *only* if one is attempting to open the raw drive (d partition)? - Gene Stark *** /sys/i386/isa/wd.c.pk-0.2.4 Sat Jun 26 07:32:43 1993 --- /sys/i386/isa/wd.c Sat Jul 17 07:37:12 1993 *************** *** 752,758 **** du->dk_dd.d_secpercyl = 17*8; du->dk_state = WANTOPEN; du->dk_unit = unit; ! du->dk_flags &= ~DKFL_QUIET; /* read label using "c" partition */ if (msg = readdisklabel(makewddev(major(dev), wdunit(dev), WDRAW), --- 752,761 ---- du->dk_dd.d_secpercyl = 17*8; du->dk_state = WANTOPEN; du->dk_unit = unit; ! if (part == WDRAW) ! du->dk_flags |= DKFL_QUIET; ! else ! du->dk_flags &= ~DKFL_QUIET; /* read label using "c" partition */ if (msg = readdisklabel(makewddev(major(dev), wdunit(dev), WDRAW), -- stark@cs.sunysb.edu