Return to BSD News archive
Newsgroups: comp.os.386bsd.bugs Path: sserve!newshost.anu.edu.au!munnari.oz.au!news.Hawaii.Edu!ames!agate!howland.reston.ans.net!europa.eng.gtefsd.com!uunet!pipex!sunic!news.funet.fi!news.cs.tut.fi!butler.cc.tut.fi!news.eunet.fi!KremlSun!kiae!relcom!ache From: "Andrew A. Chernov, Black Mage" <ache@astral.msk.su> Subject: Re: sio pk0.2.4 patch: new probe() and TIOC_ ioctls References: <IQTIBSiCD0@astral.msk.su> <AAeepRi4Z0@zebub.msk.su> Sender: ache@newcom.kiae.su (Andrew A. Chernov) Organization: KIAE Date: Thu, 19 Aug 1993 01:52:10 GMT X-Newsreader: NN v6.4.18 Message-ID: <1993Aug19.015210.13819@newcom.kiae.su> Lines: 37 In <AAeepRi4Z0@zebub.msk.su> vak@zebub.msk.su writes: >> In comp.os.386bsd.bugs ache@astral writes: >> >2) TIOCM_XXX ioctl flags were implemented incorrectly. >> > As the result, uucico could not determine the correct carrier state >> > and loop forever waiting for carrier detect. >> Oh, it is well know bug. But, what kind of uucico you use? Standard Taylor >> uucico don't deal with TIOCM_XXX stuff. >I use taylor uucp, version 1.04. When waiting for carrier, >it issues ioctl (TIOCMGET) and tests for TIOCM_CD (see file unix/serial.c). grep TIOCM unix/serial.c found only TIOCMODEM and not TIOCMGET. v1.04 doesn't know TIOCMXXX features. You need some relax, IMHO. But... I remember: long ago I play with TIOCM_CD in Taylor's uucp, maybe you use non-original sources but sources hacked by me? In any case result is nice! :-) >> > case TIOCMGET: >> >! *(int*)data = TIOCM_LE; /* line always enabled */ >> >> Maybe, it is more correct to change this to: >> >> *(int*)data = 0; >> if (inb(iobase + com_ier)) *(int*)data |= TIOCM_LE; >Maybe. But, according to some 8250 documentations, IER is write-only >register. I think, there should exist chips, for which this is true. sio.c use inb(iobase + com_ier) in several places and mainly in probe routine for all chips, so I simple follow to sio.c code. Moreover, old com.c from cgd use this feature too. -- In-This-Life: Andrew A. Chernov | "Hay mas dicha, mas contento Internet: ache@astral.msk.su | "Que adorar una hermosura FIDOnet: 2:5020/23.34 | "Brujuleada entre los lejos RELCOM Development Team, Moscow, Russia | "De lo imposible?!" (Calderon)