*BSD News Article 30296


Return to BSD News archive

Xref: sserve comp.os.386bsd.bugs:2212 comp.protocols.ppp:4060
Newsgroups: comp.os.386bsd.bugs,comp.protocols.ppp
Path: sserve!newshost.anu.edu.au!munnari.oz.au!bunyip.cc.uq.oz.au!harbinger.cc.monash.edu.au!msuinfo!agate!howland.reston.ans.net!spool.mu.edu!cass.ma02.bull.com!as02.bull.oz.au!melb.bull.oz.au!zen!sjg
From: sjg@zen.void.oz.au (Simon J. Gerraty)
Subject: Re: priority queuing bug in *BSD ppp (if_ppp.c)
Keywords: ppp BSD
Message-ID: <1994May10.130723.28188@zen.void.oz.au>
Organization: Zen programming...
Date: Tue, 10 May 1994 13:07:23 GMT
References: <1994May7.004353.695@fasterix.frmug.fr.net>
Lines: 17

pb@fasterix.frmug.fr.net (Pierre Beyssac) writes:
> Mail copy to the FreeBSD/NetBSD mailing-lists and Paul Mackerras
>(paulus@cs.anu.edu.au) 
>	    if (INTERACTIVE(ntohs(p & 0xffff)) || INTERACTIVE(ntohs(p >> 16)))

I suspect that

	if (INTERACTIVE(ntohs(p) & 0xffff) || INTERACTIVE(ntohs(p) >> 16))

is more likely to resolve the ntohs() problem without changing the
meaning of the code.  ntohs(p >> 16) and ntohs(p) >> 16 can
produce _very_ different results.

-- 
Simon J. Gerraty        <sjg@zen.void.oz.au>

#include <disclaimer>   /* imagine something _very_ witty here */