*BSD News Article 30772


Return to BSD News archive

Xref: sserve comp.os.386bsd.bugs:2231 comp.protocols.ppp:4223
Path: sserve!newshost.anu.edu.au!munnari.oz.au!news.Hawaii.Edu!ames!hookup!usc!howland.reston.ans.net!europa.eng.gtefsd.com!MathWorks.Com!transfer.stratus.com!xylogics.com!Xylogics.COM!carlson
From: carlson@Xylogics.COM (James Carlson)
Newsgroups: comp.os.386bsd.bugs,comp.protocols.ppp
Subject: Re: priority queuing bug in *BSD ppp (if_ppp.c)
Date: 11 May 1994 12:41:36 GMT
Organization: Xylogics Incorporated
Lines: 21
Distribution: world
Message-ID: <2qqjq0$iim@newhub.xylogics.com>
References: <1994May7.004353.695@fasterix.frmug.fr.net> <1994May10.130723.28188@zen.void.oz.au>
Reply-To: carlson@xylogics.com
NNTP-Posting-Host: steam.xylogics.com
Keywords: ppp BSD

In article <1994May10.130723.28188@zen.void.oz.au>, sjg@zen.void.oz.au (Simon J. Gerraty) writes:
|> pb@fasterix.frmug.fr.net (Pierre Beyssac) writes:
|> > Mail copy to the FreeBSD/NetBSD mailing-lists and Paul Mackerras
|> >(paulus@cs.anu.edu.au) 
|> >	    if (INTERACTIVE(ntohs(p & 0xffff)) || INTERACTIVE(ntohs(p >> 16)))
|> 
|> I suspect that
|> 
|> 	if (INTERACTIVE(ntohs(p) & 0xffff) || INTERACTIVE(ntohs(p) >> 16))
|> 
|> is more likely to resolve the ntohs() problem without changing the
|> meaning of the code.  ntohs(p >> 16) and ntohs(p) >> 16 can
|> produce _very_ different results.

I'm sure it does.  "ntohs(p)>>16" is meaningless -- it should return a
constant zero by definition.

--
James Carlson <carlson@xylogics.com>            Tel:  +1 617 272 8140
Annex Software Support / Xylogics, Inc.               +1 800 225 3317
53 Third Avenue / Burlington MA  01803-4491     Fax:  +1 617 272 2618