*BSD News Article 3330


Return to BSD News archive

Newsgroups: comp.unix.bsd
Path: sserve!manuel!munnari.oz.au!uunet!wupost!darwin.sura.net!mojo.eng.umd.edu!pandora.pix.com!stripes
From: stripes@pix.com (Josh Osborne)
Subject: Possable pccons.c bug in 0.1
Message-ID: <Bsqyun.Jp5@pix.com>
Sender: news@pix.com (The News Subsystem)
Nntp-Posting-Host: pandora.pix.com
Organization: Project GLUE, Merriversity of Uniland, College Purgatory
Date: Mon, 10 Aug 1992 02:56:45 GMT
Lines: 28

In sput() in pccons.c (I think it's with the ISA drivers) we have:

....
	was = *cp;
	*cp = (u_short) 0xA55A;
	if (*cp != 0xA55A) {
			addr_6845 = MONO_BASE;
			vs.color=0;
	} else {
			*cp = was;
			addr_6845 = CGA_BASE;
			Crtat = Crtat + (CGA_BUF-MONO_BUF)/CHR;
			vs.color=1;
	}
....

I *think* it looks like the if should be
	if (was != 0xA55A) ...

However I don't have a monocrome graphics card to try out...

Sorry if the bug has been detected (or if I misread good code).
-- 
           stripes@pix.com              "Security for Unix is like
      Josh_Osborne@Real_World,The          Multitasking for MS-DOS"
      "The dyslexic porgramer"                  - Kevin Lockwood
We all agree on the necessity of compromise.  We just can't agree on
when it's necessary to compromise.       - Larry Wall