*BSD News Article 33972


Return to BSD News archive

Xref: sserve comp.os.386bsd.questions:12137 comp.os.386bsd.development:2368 comp.os.386bsd.misc:3074
Newsgroups: comp.os.386bsd.questions,comp.os.386bsd.development,comp.os.386bsd.misc
Path: sserve!newshost.anu.edu.au!harbinger.cc.monash.edu.au!bunyip.cc.uq.oz.au!munnari.oz.au!news.Hawaii.Edu!ames!hookup!yeshua.marcam.com!usc!howland.reston.ans.net!EU.net!sun4nl!cs.vu.nl!kjb
From: kjb@cs.vu.nl (Kees J. Bot)
Subject: Re: Why does FreeBSD 1.1.5 say gets() is unsafe?
Message-ID: <Ctv31z.6EA@cs.vu.nl>
Sender: news@cs.vu.nl
Organization: Fac. Wiskunde & Informatica, VU, Amsterdam
References: <30lrf3$2ii@acmez.gatech.edu> <311m2e$o33@agate.berkeley.edu> <jmonroyCtMGq2.IC6@netcom.com> <Ctn5yy.3I0@cs.vu.nl> <31cf70$3c@Starbase.NeoSoft.COM> <CturD6.3C1@cs.vu.nl>
Date: Mon, 1 Aug 1994 15:01:10 GMT
Lines: 14

kjb@cs.vu.nl (Kees J. Bot) wrotes buggy code:

>	if (c == EOF) {
>		if (ferror(fp)) fatal(file);
		deallocate(line);			/* missing */
>		return NULL;
>	}

Two articles posted, two mistakes.  Usenet being usenet people will
probably comment heavily on the small mistakes, and ignore all the rest
I said.  :-)
--
	                        Kees J. Bot  (kjb@cs.vu.nl)
	              Systems Programmer, Vrije Universiteit Amsterdam