*BSD News Article 38433


Return to BSD News archive

Path: sserve!newshost.anu.edu.au!munnari.oz.au!spool.mu.edu!howland.reston.ans.net!Germany.EU.net!EU.net!uunet!news.iij.ad.jp!wnoc-tyo-news!wnoc-sfc-news!kogwy!hosokawa
From: hosokawa@mt.cs.keio.ac.jp (HOSOKAWA Tatsumi)
Newsgroups: comp.os.386bsd.bugs
Subject: APM driver bug (FreeBSD 2.0R)
Date: 26 Nov 1994 10:06:13 GMT
Organization: Tokoro Laboratory, Keio University, Yokohama Japan.
Lines: 45
Distribution: world
Message-ID: <3b71al$ri6@kogwy.cc.keio.ac.jp>
NNTP-Posting-Host: steyr.mt.cs.keio.ac.jp
X-Newsreader: mnews [version 1.18PL3] 1994-08/01(Mon)

Hi,

I found a bug of (experimental) APM BIOS driver of FreeBSD 2.0R
(Sorry, it's my mistake...).  It is not critical bug, but this bug can
causes the driver to make an error in probing APM BIOS.

*** sys.org/i386/i386/locore.s	Fri Nov 18 05:27:34 1994
--- sys/i386/i386/locore.s	Sat Nov 26 18:45:13 1994
***************
*** 374,380 ****
  	.long	0
  	.word	APM_INIT_CS_SEL
  
! 	movw	%ax, _apm_version-KERNBASE
  	movl	%ebx, _apm_cs_entry-KERNBASE
  	movw	%cx, _apm_cs32_base-KERNBASE
  	shrl	$16, %ecx
--- 374,380 ----
  	.long	0
  	.word	APM_INIT_CS_SEL
  
! 	movl	%eax, _apm_version-KERNBASE
  	movl	%ebx, _apm_cs_entry-KERNBASE
  	movw	%cx, _apm_cs32_base-KERNBASE
  	shrl	$16, %ecx
*** sys.org/i386/apm/apm.c	Tue Nov 15 14:09:18 1994
--- sys/i386/apm/apm.c	Sat Nov 26 18:52:44 1994
***************
*** 378,386 ****
  		return 0;
  	}
  
- 	if ((apm_version & 0xff00) != 0x0100) return 0;
- 	if ((apm_version & 0x00f0) >= 0x00a0) return 0;
- 	if ((apm_version & 0x000f) >= 0x000a) return 0;
  	return -1;
  }
  
--- 378,383 ----

---
     -----------------------------------------------------------
     HOSOKAWA, Tatsumi               (hosokawa@mt.cs.keio.ac.jp)
     Dept. of Computer Science, Keio University, Yokohama, Japan
     -----------------------------------------------------------