Return to BSD News archive
Path: sserve!manuel.anu.edu.au!munnari.oz.au!sgiblab!darwin.sura.net!paladin.american.edu!news.univie.ac.at!hp4at!mcsun!sunic!dkuug!dkuug!flshub!phk From: phk@data.fls.dk (Poul-Henning Kamp) Newsgroups: comp.unix.bsd Subject: Re: [386BSD] Patchkit and slip? Message-ID: <1992Oct14.205902.10422@data.fls.dk> Date: 14 Oct 92 20:59:02 GMT References: <Bw2Dpz.66o@ssesco.com> Organization: FLS Data A/S, Valby, Copenhagen, Denmark. Lines: 45 cwc@ssesco.com (Craig W. Carlson) writes: >I installed the patch kit last night and everything went fine until I tried >to use slip. The slip configuration seemed to work, and I seemed to be able to >send packets out, but incoming packets appeared to be getting thrown away (at >least it seemed that way by watching the lights on my modem). I just mailed this to terry: ----------------------------------------------------------------------------- Hi Terry, about the patch-kit: patch00019 has a bug in it, it might be me, it might be you, I don't care, but it should be fixed: Part#2 leaves an return in /sys/net/if_sl.c line ~637 which totally disables receiving SLIP packets. I have marked it here below in a chunk from the source: ---------------- sc = (struct sl_softc *)tp->t_sc; if (sc == NULL) return; if (c > 255 || !(tp->t_state&TS_CARR_ON)) { /* XXX 30 Aug 92*/ sc->sc_flags |= SC_ERROR; return; } return; /* THIS IS WRONG !!!!, remove it !!! */ ++sc->sc_bytesrcvd; ---------------------------- The newvers patch (#1 ?) is (still) not right, there needs to be appended 'newvers' to the SYSTEM_DEP line Patchs #26 & #56 fails utterly on machines not having the ETC01 dist, some kind of check should be made before attempting, like checking the existence of the directory in question. -- phk@data.fls.dk || $HOME Poul-Henning Kamp || FLS DATA A/S || sweet Phone: (+45) 36 18 12 35 ||