*BSD News Article 7729


Return to BSD News archive

Path: sserve!manuel.anu.edu.au!munnari.oz.au!spool.mu.edu!olivea!charnel!sifon!michaelm
From: michaelm@pike.ee.mcgill.ca (Michael Moscovitch)
Newsgroups: comp.unix.bsd
Subject: [386bsd] problem with slip after patchkit (solution)
Message-ID: <1992Nov15.071209.4230@sifon.cc.mcgill.ca>
Date: 15 Nov 92 07:12:09 GMT
Sender: news@sifon.cc.mcgill.ca
Organization: McGill University - VLSI Laboratory, Montreal, CANADA.
Lines: 18
Nntp-Posting-Host: pike.ee.mcgill.ca


I recently reloaded 386bsd 0.1 onto my machine and applied the patchkit
upto patch 58. I then noticed that slip was nolonger working. There
was also another message on the net from someone that had a similar
problem but thought it might be related to bits per character and
parity. I placed a few printfs in com.c and determined that 8 bit and no
parity is being set correctly. Then I noticed an obvious problem in
net/if_sl.c. It seems that patch 19 left an extra return statement in
slinput(). Getting rid of this fixed everything up just fine. 

I don't have a diff, but it should be pretty obvious. Just look
for a return that unconditionally
prevents the rest of the function from being
executed.

-- 
<Mike>
michaelm@pike.ee.mcgill.ca