Return to BSD News archive
Received: by minnie.vk1xwt.ampr.org with NNTP
id AA5242 ; Tue, 22 Dec 92 17:00:42 EST
Newsgroups: comp.unix.bsd
Path: sserve!manuel.anu.edu.au!munnari.oz.au!spool.mu.edu!caen!hellgate.utah.edu!fcom.cc.utah.edu!cs.weber.edu!terry
From: terry@cs.weber.edu (A Wizard of Earth C)
Subject: Re: 386BSD - Bug in UFS file system + proposed fix
Message-ID: <1992Dec20.023343.29732@fcom.cc.utah.edu>
Sender: news@fcom.cc.utah.edu
Organization: University of Utah Computer Center
References: <1992Dec16.012248.8123@moxie.hou.tx.us> <1992Dec16.211422.3663@fcom.cc.utah.edu> <1992Dec17.140123.9952@moxie.hou.tx.us>
Date: Sun, 20 Dec 92 02:33:43 GMT
Lines: 43
In article <1992Dec17.140123.9952@moxie.hou.tx.us>, hackney@moxie.hou.tx.us (Greg Hackney) writes:
|> terry@cs.weber.edu (A Wizard of Earth C) writes:
|>
|> > This fix seems a bad thing.
|>
|> The fix we proposed for ufs_vnops.c, is identical to 386BSD's sister code
|> residing in nfs_vnops.c. I'm not sure why ufs_vnops.c got changed to
|> something different.
|>
|> > In particular, you *don't* want to allow a
|> > file which is world read or world execute to be read/executed by someone
|> > who is a member of a group denied access.
|>
|> Did you try the code? On my system, group denied access works properly.
I tried the code, but I basicaly "unfixed" a fix I'd put in but not posted;
your code is correct. I manually apply all patches any more (given that I
have to maintain the code at a recent patch level to produce ordered diffs).
This also explains one of the "empty" patches in the Alpha patch kit during
testing before the beta was released. Basically, I didn't keep an original
of the file.
When "applying" your patch, I removed mine, putting the bug back into the
code; I also zapped the permission checking entirely (ie: allowed permission
in all cases). Testing shows it working fine now.
|> If no one else is having these (major) permissions problems when
|> using NFS across 2 386BSD systems, then we need to go back and dig
|> deeper into why the modes aren't working. Are you saying that it works
|> properly for you?
Not necessary. Sorry for the false alarm.
Terry Lambert
terry@icarus.weber.edu
terry_lambert@novell.com
---
Any opinions in this posting are my own and not those of my present
or previous employers.
-------------------------------------------------------------------------------
"I have an 8 user poetic license" - me
Get the 386bsd FAQ from agate.berkeley.edu:/pub/386BSD/386bsd-0.1/unofficial
-------------------------------------------------------------------------------