*BSD News Article 9198


Return to BSD News archive

Received: by minnie.vk1xwt.ampr.org with NNTP
	id AA5336 ; Wed, 23 Dec 92 13:00:53 EST
Newsgroups: comp.unix.bsd
Path: sserve!manuel.anu.edu.au!munnari.oz.au!spool.mu.edu!uwm.edu!cs.utexas.edu!wotan.compaq.com!moxie!hackney
From: hackney@moxie.hou.tx.us (Greg Hackney)
Subject: Re: 386BSD - Bug in UFS file system + proposed fix
Organization: Home
References: <1992Dec16.012248.8123@moxie.hou.tx.us> <1992Dec16.211422.3663@fcom.cc.utah.edu> <1992Dec21.081943.8395@runx.oz.au>
Message-ID: <BzMyAB.1y2@moxie.hou.tx.us>
Date: Tue, 22 Dec 1992 00:49:22 GMT
Lines: 20

bde@runx.oz.au (Bruce Evans) writes:

> I think the fix is correct.  It seems to be the same patch that I posted
> the other day, but is backwards.
> What is going on here?  I think that the version in the ".orig" file is
> correct, but the version in the "new" file is what's already in 386BSD-0.1,
> and wrong.

Bruce,

The correct line in ufs_vnops.c is:

 	if ((ip->i_mode & mode) != 0)

I think that the confusion may lie in the fact that you probably
have an older version of ufs_vnops.c.  It used to be the correct code,
and got changed later. I'm not sure when.
--
Greg