*BSD News Article 9499


Return to BSD News archive

Received: by minnie.vk1xwt.ampr.org with NNTP
	id AA5855 ; Fri, 01 Jan 93 01:58:40 EST
Newsgroups: comp.unix.bsd
Path: sserve!manuel.anu.edu.au!munnari.oz.au!spool.mu.edu!sdd.hp.com!apollo.hp.com!netnews
From: sommerfeld@apollo.hp.com (Bill Sommerfeld)
Subject: Re: [386bsd] SLIP is one way...
Sender: usenet@apollo.hp.com (Usenet News)
Message-ID: <SOMMERFELD.93Jan2193742@unknown.apollo.hp.com>
In-Reply-To: pozar@kumr.lns.com's message of 2 Jan 93 17:33:47 GMT
Date: Sun, 3 Jan 1993 00:34:22 GMT
Lines: 39
References: <1993Jan2.173347.10168@kumr.lns.com>
Nntp-Posting-Host: snarfblatt.ch.apollo.hp.com
Organization: Hewlett Packard

In article <1993Jan2.173347.10168@kumr.lns.com> pozar@kumr.lns.com (Tim Pozar) writes:

      With building any kernel the best I can get on slip sessions are
   packets going out a slip link and not making it back in.  The machine on
   the other end will echo pings back, but the 386BSD box is not getting them
   back.

You probably installed the patch kit.. in particular, patch 19.

Part 2 of patch 19 appears to contain a bogus duplicate return:

***************
*** 623,629 ****
        sc = (struct sl_softc *)tp->t_sc;
        if (sc == NULL)
                return;
!       if (!(tp->t_state&TS_CARR_ON))  /* XXX */
                return;

        ++sc->sc_bytesrcvd;
--- 630,640 ----
        sc = (struct sl_softc *)tp->t_sc;
        if (sc == NULL)
                return;
!       if (c > 255 || !(tp->t_state&TS_CARR_ON)) {       /* XXX 30 Aug 92*/
!               sc->sc_flags |= SC_ERROR;
!               return;
!       }
!
                return;		<-****!!!!****

        ++sc->sc_bytesrcvd;

... which turns slinput into a noop.

I just deleted that return from my kernel, rebuilt it, rebooted it,
and I'm now typing this message over a SLIP link..

						- Bill